🪐 Improve thebe bundling #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
approved these changes
Jun 13, 2023
Comment on lines
+37
to
+39
| "thebe-core": "^0.2.3", | ||
| "thebe-lite": "^0.2.3", | ||
| "thebe-react": "^0.2.3", |
There was a problem hiding this comment.
Love that these are fixed versions @stevejpurves -- thank you!
| @@ -0,0 +1,351 @@ | |||
| import { describe, expect, test } from 'vitest'; | |||
Comment on lines
+26
to
+31
| <ThebeRenderMimeRegistryProvider> | ||
| <ThebeSessionProvider start={false} name={article.slug}> | ||
| {!hide_title_block && ( | ||
| <FrontmatterBlock kind={article.kind} frontmatter={article.frontmatter} /> | ||
| )} | ||
| <NotebookProvider siteConfig={false} page={article}> |
There was a problem hiding this comment.
I am looking forward to some of these being merged into a single provider as we move to supporting across different articles!
test/index.js
Outdated
| @@ -0,0 +1,26 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Is this file intentionally added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
thebebased compute in the myst themes, this is updated to use new provider inthebe-reactand has some selected changes from #64 and #70 which this PR will supercede: