Improve cpp code generation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly generate field and methods with the right level of privacy (public/private/protected). - Generate .h file instead of .cpp - Add #include statement for other class in the puml file - Protect against multiple inclusion with preprocessor
…ss are not handled)
|
Added modification to handle template type: issue #52 |
…nnector with direction
…nnector with direction
# Conflicts: # src/parser/plantuml.pegjs
|
Thanks for PR. There is generated test for each language which just verify generated output: Line 45 in eaa9e99 you should update this table: Line 123 in e2ad307 which map generated file extension for each language. and update&rename this file: https://github.com/jupe/puml2code/blob/master/test/data/car.cpp.cpp I just activated CI for PR so we can see when everything is ready for merging :) |
jupe
reviewed
Apr 13, 2020
jupe
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add the following effect during cpp code generation:
Does not change anything for other language.
Tests
The cpp test is not passing anymore, let me know how to update the template, so I can fix that. However, the result for the car.puml file are correct.
Related issues
#50
Thank you for this great code base!
PS: js is not my primary language and I never used handlebars before... My code is based on what is done for ECMAScript6.