Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiproof in PINE #41

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Support multiproof in PINE #41

merged 1 commit into from
Dec 21, 2023

Conversation

junyechen1996
Copy link
Owner

Reviewer's note: stacked PR on #40 .

poc/flp_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. I suggest removing some of the type hints, as these tend to turn into code rot. (See inline comment.)

poc/flp_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
poc/vdaf_pine.py Outdated Show resolved Hide resolved
@junyechen1996 junyechen1996 force-pushed the junyec/multiproof-refactor branch from 730891f to 67ff536 Compare December 21, 2023 16:04
Base automatically changed from junyec/multiproof-refactor to main December 21, 2023 16:05
@junyechen1996 junyechen1996 merged commit 2497295 into main Dec 21, 2023
2 checks passed
@junyechen1996 junyechen1996 deleted the junyec/multiproof branch December 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants