Discovery fails for special/empty class names #87
Comments
|
A simple reproducer: https://github.com/jrhee17/armeria/tree/poc/testng-failure Can be done by running |
|
Thanks for the reproducer! We'll look into it. |
ikhoon
pushed a commit
to line/armeria
that referenced
this issue
Jan 2, 2024
Motivation: Recently we have enabled PTS which causes an error when trying to run testNg tests. ``` Execution failed for task ':core:testNg'. > Predictive Test Selection only supports JUnit Platform. ``` It has been pointed out that `TestNg` is supported through `junit-platform`. ref: https://docs.gradle.com/enterprise/predictive-test-selection/#_frameworks_and_languages I see no reason we shouldn't just use `junit-platform` overall as our default test framework launcher. ref: https://gradle.slack.com/archives/C05975D6V7H/p1701969512592219 Note that we are unable to add the testNg globally by default due to the following issue: junit-team/testng-engine#87 Modifications: - Added a test engine `testng` to testing runtime - Modified to always use `useJUnitPlatform()` Result: - We can run testNg tests with PTS enabled
|
@jrhee17 I checked out your branch but was unable to reproduce the issue. Do you have any idea why it worked for me? |
|
I've found a different reproducer in 72d4f66 and fixed that. That should fix your issue as well. |
marcphilipp
changed the title
testng engine fails to handle dollar sign classnames
eottabom
pushed a commit
to eottabom/armeria
that referenced
this issue
Jan 18, 2024
Motivation: Recently we have enabled PTS which causes an error when trying to run testNg tests. ``` Execution failed for task ':core:testNg'. > Predictive Test Selection only supports JUnit Platform. ``` It has been pointed out that `TestNg` is supported through `junit-platform`. ref: https://docs.gradle.com/enterprise/predictive-test-selection/#_frameworks_and_languages I see no reason we shouldn't just use `junit-platform` overall as our default test framework launcher. ref: https://gradle.slack.com/archives/C05975D6V7H/p1701969512592219 Note that we are unable to add the testNg globally by default due to the following issue: junit-team/testng-engine#87 Modifications: - Added a test engine `testng` to testing runtime - Modified to always use `useJUnitPlatform()` Result: - We can run testNg tests with PTS enabled
minwoox
pushed a commit
to line/armeria
that referenced
this issue
Jan 29, 2024
Motivation: junit-team/testng-engine#87 has been resolved which means that we don't need special handling for testNg Modifications: - Removed special logic for testNg - Added junit's `testng-engine` globally Result: - Cleaner gradle script <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The full stacktrace:
The classname in question is likely one of the following:
https://github.com/line/armeria/blob/3f54be0ce4370b24977994e247fa3816fde25e29/core/src/test/java/com/linecorp/armeria/server/ServiceNamingTest.java#L313
Another issue was found which didn't contain only dollar sign class names:
The class for this case was generated by the following protobuf message
https://github.com/line/armeria/blob/3f54be0ce4370b24977994e247fa3816fde25e29/scalapb/scalapb_2.13/src/test/proto/hello.proto#L23
The text was updated successfully, but these errors were encountered: