Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@DataProvider(parallel = true) should be supported #4

Closed
marcphilipp opened this issue Jul 9, 2021 · 0 comments · Fixed by #6
Closed

@DataProvider(parallel = true) should be supported #4

marcphilipp opened this issue Jul 9, 2021 · 0 comments · Fixed by #6
Assignees
@marcphilipp
Labels
bug Something isn't working
Milestone
1.0.0-M2

Comments

@marcphilipp
Copy link
Member

Currently, this throws an exception.

Reproducer: https://github.com/nebula-plugins/gradle-nebula-integration/tree/a2950c001af725a4ea185b86dbbaf34795ee5407/testng-junit-platform
@marcphilipp marcphilipp added the bug Something isn't working label Jul 9, 2021
@marcphilipp marcphilipp added this to the 1.0.0-M2 milestone Jul 9, 2021
@marcphilipp marcphilipp self-assigned this Jul 9, 2021
marcphilipp added a commit that referenced this issue Jul 9, 2021
@marcphilipp
Fix parallel data providers
0932e0a 
Since `org.testng.ITestNGMethod#getId` is not reliable, the execution
listener now uses the ITestResult as a key to find the correct
invocation and does not eagerly report the method container as finished
but relies on onAfterClass to do so. This approach is also used by
Gradle's listener implementation so it should be robust.

Fixes #4.
@marcphilipp marcphilipp mentioned this issue Jul 9, 2021
Merged
marcphilipp added a commit that referenced this issue Jul 9, 2021
@marcphilipp
Fix parallel data providers (#6)
64aef98 
Since `org.testng.ITestNGMethod#getId` is not reliable, the execution
listener now uses the `ITestResult` as a key to find the correct
invocation and does not eagerly report the method container as finished
but relies on onAfterClass to do so. This approach is also used by
Gradle's listener implementation so it should be robust.

Fixes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcphilipp marcphilipp

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-M2
Development

Successfully merging a pull request may close this issue.

Fix parallel data providers junit-team/testng-engine
1 participant
@marcphilipp