Simplify global lock coarsening #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only acquire global read/write lock on the nodes immediately below the engine descriptor and ignore other locks when a global read-write lock is requested.
marcphilipp
force-pushed
the
marc/simplify-global-lock-coarsening
branch
from
56df3ca
to
7413dfa
Compare
leonard84
approved these changes
Sep 18, 2024
| @@ -52,7 +52,9 @@ private void walk(TestDescriptor globalLockDescriptor, TestDescriptor testDescri | |||
| NodeExecutionAdvisor advisor) { | |||
| Set<ExclusiveResource> exclusiveResources = getExclusiveResources(testDescriptor); | |||
| if (exclusiveResources.isEmpty()) { | |||
| advisor.useResourceLock(testDescriptor, globalReadLock); | |||
| if (globalLockDescriptor.equals(testDescriptor)) { | |||
There was a problem hiding this comment.
🧐 Maybe add a comment on what this means.
marcphilipp
added a commit
that referenced
this pull request
Sep 19, 2024
Only acquire global read/write lock on the nodes immediately below the engine descriptor and ignore other locks when a global read-write lock is requested. (cherry picked from commit 67a5a2f)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only acquire global read/write lock on the nodes immediately below the
engine descriptor and ignore other locks when a global read-write lock
is requested.