Run isolated tasks last #4004
Merged
Run isolated tasks last #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonard84
approved these changes
Sep 18, 2024
Comment on lines
+160
to
+161
| Deque<ExclusiveTask> isolatedTasks = new LinkedList<>(); | ||
| Deque<ExclusiveTask> sameThreadTasks = new LinkedList<>(); |
There was a problem hiding this comment.
🤔 why are we using LinkedList instead of ArrayDeque?
It will probably not really matter performance wise.
There was a problem hiding this comment.
I was wondering that, too, but kept using LinkedList since it was already in place.
| @@ -155,29 +157,34 @@ public void invokeAll(List<? extends TestTask> tasks) { | |||
| new ExclusiveTask(tasks.get(0)).execSync(); | |||
| return; | |||
| } | |||
| Deque<ExclusiveTask> nonConcurrentTasks = new LinkedList<>(); | |||
| Deque<ExclusiveTask> isolatedTasks = new LinkedList<>(); | |||
There was a problem hiding this comment.
🤔 The only thing that is a bit weird is that isolated tasks can only be top-level tasks, yet this is invoked on multiple levels. Probably not worth changing.
There was a problem hiding this comment.
We could have a different class for the top-level task and other tasks. 🤔
.../junit/platform/engine/support/hierarchical/ForkJoinPoolHierarchicalTestExecutorService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3928.