Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use "wrap semantics" for started/finished and opened/closed listener methods #3117

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Dec 30, 2022

  • Call TestExecutionListener finish methods in reverse order
  • Call EngineExecutionListener.executionFinished method in reverse order
  • Call LauncherDiscoveryListener.class finish methods in reverse order
  • Call LauncherSessionListener closed method in reverse order
  • Reuse CollectionUtils.forEachInReverseOrder
  • Optimize common cases

Resolves #3082.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp self-assigned this Dec 30, 2022
@marcphilipp marcphilipp marked this pull request as ready for review December 30, 2022 14:37
@marcphilipp marcphilipp force-pushed the marc/3082-listener-iteration-order branch from 52349c7 to 042548e Compare January 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "wrap" semantics for started/finished and opened/closed listener event pairs
2 participants