Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupiterTestEngine attempts to resolve unique IDs that belong to other engines #1026

Closed
1 task done
sbrannen opened this issue Aug 19, 2017 · 0 comments
Closed
1 task done

JupiterTestEngine attempts to resolve unique IDs that belong to other engines #1026

sbrannen opened this issue Aug 19, 2017 · 0 comments
Assignees
@sbrannen
Labels
component: Jupiter theme: diagnostics type: bug
Milestone
5.0 RC3

Comments

@sbrannen
Copy link
Member

sbrannen commented Aug 19, 2017 •
edited
Loading

Overview

Currently, the JupiterTestEngine needlessly attempts to resolve Unique IDs that clearly belong to other test engines. This is because JavaElementsResolver.resolveUniqueId(UniqueId) completely ignores the Engine ID and then blindly attempts to resolve the supplied Unique ID. Consequently, the JupiterTestEngine always logs a warning about not being able to resolve a Unique ID that it was never meant to resolve.

Related Issues

Deliverables

  • Ensure that the JupiterTestEngine does not attempt to resolve Unique IDs that belong to other test engines.
@sbrannen sbrannen added this to the 5.0 RC3 milestone Aug 19, 2017
@sbrannen sbrannen self-assigned this Aug 19, 2017
@ghost ghost removed the status: in progress label Aug 19, 2017
@noopur2507 noopur2507 mentioned this issue Aug 19, 2017
Closed
2 tasks
@marcphilipp marcphilipp mentioned this issue Aug 28, 2017
Open
5 tasks
Andrei94 pushed a commit to Andrei94/junit5 that referenced this issue Jun 23, 2018
@sbrannen @Andrei94
Ignore Unique IDs from other test engines in JupiterTestEngine
e517f46 
Prior to this commit, the JupiterTestEngine needlessly attempted to
resolve Unique IDs that clearly belong to other test engines. This is
because JavaElementsResolver.resolveUniqueId(UniqueId) ignored the
Engine ID and then blindly attempted to resolve the supplied Unique ID.
Consequently, the JupiterTestEngine always logged a warning about not
being able to resolve a Unique ID that it was never meant to resolve.

This commit addresses this issue by ignoring Unique IDs selected via one
of the DiscoverySelectors.selectUniqueId() methods if the Unique ID
belongs to a different test engine.

Fixes: junit-team#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
component: Jupiter theme: diagnostics type: bug
Projects
None yet
Milestone
5.0 RC3
Development

No branches or pull requests
1 participant
@sbrannen