Support more return types for the @Parameters method. Fixes #700. #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,15 +313,24 @@ public Parameterized(Class<?> klass) throws Throwable { | |||
| return runners; | |||
| } | |||
|
|
|||
| private Runner createRunner(String pattern, int index, | |||
There was a problem hiding this comment.
Can you give this a slightly different name just to make absolutely sure we don't get odd overloading effects on later changes?
|
Nice. One quick request. |
|
@dsaff I renamed the method. |
| @@ -281,15 +313,25 @@ public Parameterized(Class<?> klass) throws Throwable { | |||
| return runners; | |||
| } | |||
|
|
|||
| private Runner createRunnerWithNotNormalizedParameters(String pattern, | |||
|
@dsaff Cleaned up formatting. |
|
@stefanbirkner, FYI, it's a little easier to track in a review if we wait until the end to squash extra commits. But looks good now. Can you resolve merge conflicts, and I'll pull? Thanks. |
…m#700. Support the return types Iterator<? extends Object>, Object[] and Object[][]. You don't have to wrap arrays with Iterables and single parameters with Object arrays.
|
I rebased to current master. @dsaff Thanks for the advice about squashing. |
dsaff
pushed a commit
that referenced
this pull request
Jul 16, 2013
Support more return types for the @parameters method. Fixes #700.
|
@stefanbirkner, many thanks! Would you mind adding a note at https://github.com/junit-team/junit/wiki/4.12-release-notes ? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the return types Iterator<? extends Object>, Object[] and Object[][]. You don't have to wrap arrays with Iterables and single parameters with Object arrays.