Trim stack trace. #1028

kcooney · 2014-11-08T22:23:28Z

This is just some ideas I had for fixing #669. I haven't written tests yet; just wanted early feedback.

marcphilipp · 2014-11-10T19:24:06Z

src/main/java/org/junit/runner/notification/Failure.java

+     */
+    public String getFilteredTrace() {
+        Throwable exception = getException();
+        String fullTrace = getTrace(exception);


The above two lines can be replaced with a call to getTrace().

marcphilipp · 2014-11-10T19:25:00Z

BaseTestRunner.getFilteredTrace() would have to be removed then, right?

marcphilipp · 2014-11-10T19:27:37Z

@kcooney I like the general idea!

kcooney · 2015-03-29T22:31:32Z

I finally found time to work on this. I added lots of tests. Please take another look.

@marcphilipp I'm not sure what you meant by "BaseTestRunner.getFilteredTrace() would have to be removed then, right?"

marcphilipp · 2015-04-06T19:10:35Z

@kcooney I don't recall what I meant by that either, sorry. Never mind, then. LGTM so far, needs a bit of refactoring IMHO since it contains a few long, complex methods.

kcooney · 2015-05-02T01:08:49Z

@marcphilipp the only really long method is StackTraces.trimStackTrace() and I don't see a clean way to break it up. Did you have something particular in mind?

ashleyfrieze · 2015-05-07T15:25:38Z

src/main/java/org/junit/internal/StackTraces.java

+    static String trimStackTrace(String extracedExceptionMessage, String fullTrace) {
+        StringBuilder trimmedTrace = new StringBuilder(extracedExceptionMessage);
+        BufferedReader reader = new BufferedReader(
+            new StringReader(fullTrace.substring(extracedExceptionMessage.length())));


extraced -> extracted - typo

kcooney · 2015-05-12T23:49:36Z

I extracted a method, and added more test cases. PTAL

If it looks good, I want to squash commits before merging this pull.

kcooney · 2015-05-13T05:29:15Z

BTW, this pull won't affect the functionality of Maven (I checked), and won't likely affect Gradle. It only affects users of TextListener. The only way I can think of to get this behavior in Maven and Gradle would be for us to modify the stack trace in the exception itself.

…ass.

kcooney · 2015-06-03T16:20:07Z

I've made some more changes

Removed the changes to the JUnit 3 code. Anyone using that code can't run JUnit4-style tests, so it isn't worth potentially breaking someone
Removing that dependency allowed me to simplify the code
I also made the tests use actual stack traces, instead of fake ones hard-coded in the code. This caught a few bugs.

PTAL

In parallel, I'm experimenting with changing the actual stack trace of the thrown exception. If that works, that solution would cause the stack traces to be trimmed in Maven and Gradle

marcphilipp · 2015-07-02T19:34:45Z

Before trimming the stacktrace for Maven/Gradle, I think we should ask someone from each project if that's something they'd appreciate, shouldn't we?

kcooney · 2015-07-03T15:19:48Z

@marcphilipp I would be more interested in the feedback of Maven or Gradle users that also use JUnit. I don't think we need to reach out to the Maven or Gradle teams unless we think we would break them.

If we change the actual stack trace itself, I would be worried about breaking IDEs that already do this trimming.

The change as-is won't help many users

kcooney · 2017-01-30T05:17:20Z

I was reviewing old pool requests, and took another look at this.

Maven Surefire already has an option (enabled, by default) to trim JUnit stack traces. I think I didn't realize this before since often the stack traces I see from running JUnit tests are from JUnit tests that run other JUnit tests.

In any case, I'd like to merge this. I've merged from master, and the tests pass locally. I also moved getTrimmedStackTrace() to the Throwables class (which I don't think existed at the time when I wrote this pull)

@marcphilipp any objections to merging this?

marcphilipp

LGTM!

Update TextListener to trim stack traces. Fixes junit-team#669

… classic/non-orchestrator modes. This change should clean up test failure reporting by: - Remove test runner framework related stack frames - Truncate stack traces to a 64KB size when running under orchestrator to attempt to avoid binder transaction limits. This limit is already enforced when running in classic/non-orchestrator mode JUnit 4.13 has a really nice getTrimmedStackTrace feature, but androidx.test is fixed to 4.12 for the time being. So as a temporary workaround, copy the relevant JUnit change junit-team/junit4#1028 into this project. Fixes #729, and hopefully #269 PiperOrigin-RevId: 329797783

… classic/non-orchestrator modes. This change should clean up test failure reporting by: - Remove test runner framework related stack frames - Truncate stack traces to a 64KB size when running under orchestrator to attempt to avoid binder transaction limits. This limit is already enforced when running in classic/non-orchestrator mode JUnit 4.13 has a really nice getTrimmedStackTrace feature, but androidx.test is fixed to 4.12 for the time being. So as a temporary workaround, copy the relevant JUnit change junit-team/junit4#1028 into this project. Fixes #729, and hopefully #269 PiperOrigin-RevId: 332051125

Update TextListener to trim stack traces. Fixes junit-team#669

kcooney force-pushed the trim-stack-trace branch 2 times, most recently from 81fe75d to 11b0e34 Compare November 8, 2014 22:33

marcphilipp reviewed Nov 10, 2014
View reviewed changes

kcooney mentioned this pull request Nov 20, 2014

Cutting on stack call #669

Closed

kcooney force-pushed the trim-stack-trace branch 2 times, most recently from 44e12ce to 4f7c311 Compare March 29, 2015 22:28

kcooney force-pushed the trim-stack-trace branch 2 times, most recently from ea663e2 to 7b174b5 Compare March 29, 2015 22:34

Experimental code to filter stack traces

4930a1e

kcooney force-pushed the trim-stack-trace branch from 7b174b5 to 4930a1e Compare March 29, 2015 22:35

ashleyfrieze reviewed May 7, 2015
View reviewed changes

kcooney added 3 commits May 12, 2015 09:10

Fix line endings in StackTraces.

170d509

Extract method in StackTraces

858c057

Add test cases for stack traces from Maven Surefire and Gradle.

2d754f3

kcooney added 2 commits May 31, 2015 21:56

Remove changes to JUnit 3.x code, which simplifies the StackTraces cl…

8846d73

…ass.

Rewrite tests for StackTraces to use real stacktraces as inputs.

3488c76

kcooney force-pushed the trim-stack-trace branch from b9d955c to 7a0e410 Compare June 4, 2015 01:04

Simplify StackTraces by using StackTraceElement

3c6be5a

kcooney force-pushed the trim-stack-trace branch from 7a0e410 to 3c6be5a Compare June 4, 2015 01:18

kcooney mentioned this pull request Oct 21, 2015

Add ReducedStackTrace rule for easier interpretation of stack traces on the command line #1211

Closed

kcooney force-pushed the trim-stack-trace branch 3 times, most recently from b6f240b to 3c6be5a Compare January 30, 2017 05:03

kcooney added 2 commits January 29, 2017 21:07

Merge branch 'master' into trim-stack-trace

3b45708

Move getTrimmedStackTrace() to Throwables

21c24f7

kcooney added the 4.13 label Jan 30, 2017

marcphilipp approved these changes Feb 5, 2017

View reviewed changes

kcooney added the needs release notes update label Feb 6, 2017

kcooney merged commit ead2fe7 into junit-team:master Feb 6, 2017

kcooney deleted the trim-stack-trace branch May 16, 2017 04:50

kcooney modified the milestone: 4.13 Aug 6, 2017

sebasjm pushed a commit to sebasjm/junit4 that referenced this pull request Mar 11, 2018

Trim stack trace. (junit-team#1028)

2ec8aa9

Update TextListener to trim stack traces. Fixes junit-team#669

stefanbirkner removed the needs release notes update label Oct 23, 2018

copybara-service bot mentioned this pull request Sep 16, 2020

Trim and truncate test failure stack traces for both orchestrator and classic/non-orchestrator modes. android/android-test#730

Merged

aristotle0x01 pushed a commit to aristotle0x01/junit4 that referenced this pull request Jun 27, 2022

Trim stack trace. (junit-team#1028)

70013d3

Update TextListener to trim stack traces. Fixes junit-team#669

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trim stack trace. #1028

Trim stack trace. #1028

kcooney commented Nov 8, 2014

marcphilipp Nov 10, 2014

kcooney Mar 29, 2015

marcphilipp commented Nov 10, 2014

marcphilipp commented Nov 10, 2014

kcooney commented Mar 29, 2015

marcphilipp commented Apr 6, 2015

kcooney commented May 2, 2015

ashleyfrieze May 7, 2015

kcooney commented May 12, 2015

kcooney commented May 13, 2015

kcooney commented Jun 3, 2015

marcphilipp commented Jul 2, 2015

kcooney commented Jul 3, 2015

kcooney commented Jan 30, 2017

marcphilipp left a comment

Trim stack trace. #1028

Trim stack trace. #1028

Conversation

kcooney commented Nov 8, 2014

marcphilipp Nov 10, 2014

Choose a reason for hiding this comment

kcooney Mar 29, 2015

Choose a reason for hiding this comment

marcphilipp commented Nov 10, 2014

marcphilipp commented Nov 10, 2014

kcooney commented Mar 29, 2015

marcphilipp commented Apr 6, 2015

kcooney commented May 2, 2015

ashleyfrieze May 7, 2015

Choose a reason for hiding this comment

kcooney commented May 12, 2015

kcooney commented May 13, 2015

kcooney commented Jun 3, 2015

marcphilipp commented Jul 2, 2015

kcooney commented Jul 3, 2015

kcooney commented Jan 30, 2017

marcphilipp left a comment

Choose a reason for hiding this comment