Update index.erb to make redis-stat also working when it gets proxied #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes referencing issue junegunn#56 Intention: make redis-stat also working when proxying it. Now you can configure your webserver to act as proxy and access redis-stat via ``your-domain/your-access-page`` This was not possible before due to web-root relative paths in index.erb
|
Thanks, but looks like there are a few more places that need to be updated. Line 28, 30, and 160. Can you update? |
Added changes like in line 23 to line 28 / 30 / 160
|
Done |
|
Merged, thanks! I'll release a new version. |
rm-hull
added a commit
to rm-hull/redis-stat
that referenced
this pull request
Jun 26, 2017
* 'master' of https://github.com/junegunn/redis-stat: 0.4.14 Update index.erb to make redis-stat work when it gets proxied (junegunn#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes referencing issue #56
Intention: make redis-stat also working when proxying it.
Now you can configure your webserver to act as proxy and access redis-stat via
your-domain/your-access-pageThis was not possible before due to web-root relative paths in index.erb