-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fzf doesn't accept input #910
Comments
Please provide more details about your environment: OS distro, terminal emulator, 6ccc12c was made in January, and no one has reported this issue so far. Hmm. |
And I use
Yes, it doesn't work as expected, it just hang:
And Do you need any other information? |
echo -e "\x1b[6n"
|
Yes.
I test it in Also, I test in |
That's strange. Can you check what's going on under the hood using strace? FZF_DEFAULT_COMMAND='seq 1000000' strace -o /tmp/o -f fzf |
Trace shows that fzf successfully started child process (seq) and it worked as expected ( You seem to be using fzf binary built from source. I'm not sure if it'll make any difference, but can you test again with the prebuilt binary below? https://github.com/junegunn/fzf-bin/releases/download/0.16.7/fzf-0.16.7-linux_amd64.tgz |
Ah, the prebuilt binary works !
|
I have no idea. I used |
I have just bisected go version locally, this commit caused the issue. |
Thanks, I'll take note of that. |
Due to go std lib uses poller for os.File introducing in this commit: golang/go@c05b06a There are two changes to watch out: 1. os.File.Fd will always return a blocking fd except on bsd. 2. os.File.Read won't return EAGAIN error for nonblocking fd. So For 1, we just get tty's fd in advance and then set its block mode. For 2, we use read syscall directly to get what we wanted error(EAGAIN). Fix issue junegunn#910. Signed-off-by: Tw <tw19881113@gmail.com>
Due to go std lib uses poller for os.File introducing in this commit: golang/go@c05b06a There are two changes to watch out: 1. os.File.Fd will always return a blocking fd except on bsd. 2. os.File.Read won't return EAGAIN error for nonblocking fd. So For 1, we just get tty's fd in advance and then set its block mode. For 2, we use read syscall directly to get what we wanted error(EAGAIN). Fix issue junegunn#910. Signed-off-by: Tw <tw19881113@gmail.com>
Due to go std lib uses poller for os.File introducing in this commit: golang/go@c05b06a There are two changes to watch out: 1. os.File.Fd will always return a blocking fd except on bsd. 2. os.File.Read won't return EAGAIN error for nonblocking fd. So For 1, we just get tty's fd in advance and then set its block mode. For 2, we use read syscall directly to get what we wanted error(EAGAIN). Fix issue #910. Signed-off-by: Tw <tw19881113@gmail.com>
Today I just upgrade the fzf to 2d61691 and run fzf on current directory, but it doesn't accept any input..
I just bisect it, found that this commit is the culprit: 6ccc12c,
Any help? Thanks.
The text was updated successfully, but these errors were encountered: