Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/fixed toolbar #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

junalmeida
Copy link
Owner

@junalmeida junalmeida commented Jul 7, 2018

This is a Work In Progress PR

Summary

The proposal of this feature is to add a fixed toolbar with common actions and with the ability to be extensible.

Features

  • Base structure for fixed toolbar
  • Add tool items for commands
  • Control state of tool items that can be disabled
  • Move floating toolbars (such as debug) to the end of the fixed toolbar
  • Move action buttons of tab bar to the toolbar
  • Check unit tests coverage

vscode

# Conflicts:
#	src/vs/workbench/browser/layout.ts
#	src/vs/workbench/electron-browser/workbench.ts
#	src/vs/workbench/services/part/common/partService.ts
@Ayplow
Copy link

Ayplow commented Jul 7, 2018

I think this is a very needed feature for sure, and I'd like to help with the PR if possible, however I've got a few thoughts on the implementation.

If possible, it would be great to extend this to some other areas of the UI, maybe

  • The Menubar, potentially adding completely new sections
  • The Views (Explorer, Search, SCM, Extensions), adding custom control panels to each of them

Of course, some team input put be great here to consider what would be more than the scope of this FR.

If possible it would be really great to make use of the handles used in the keyboard shortcuts to only show these custom buttons when it is relevant.

And lastly, this would have to be configurable in a workspace file, allowing it to be shared in teams

@Ayplow
Copy link

Ayplow commented Jul 7, 2018

image
Erm - I just pulled from the repo and ran the debugger, everything else is working fine in the client. Is this happening on your end?

@junalmeida
Copy link
Owner Author

@TomSputz did'nt happened with me, but it seems to be due to new menubar I pulled today. I tested only on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants