-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potentially incorrect feature sub-selection #804
Comments
Yes, I have the same issue as well! :) |
Are your selection problems coming from Oracle layers by any chance? |
The layers coming from SQL Server 2016, and I built the Configuration Document to link to each table. |
@RenoSun Could I trouble you with a minimal SQL Server db extract + MapGuide package that demonstrates the problem? You can just provide tables with only the id/geometry columns and only a subset of the rows. |
Hi @jumpinjackie, I really hope this will help you to figure what's wrong. I tried to export only the data with ID and GEOM, but it seems not creating the same issue. So I decided to give you the data more than two columns including values with html (hyperlink). I found the highlight error doesn't occur occasionally when you select small amount of features on the map, but definitely found the wrong highlighting when selecting more than 10 features on the map. We're still using AIMS 2017, and I don't know if that may cause any issues with the mapguide-react-layout, |
@RenoSun I was finally able to take a look at your dataset and was able to reproduce the inconsistent sub-selection. This was the offending selection inferred from your provided gif (I'm posting this for future reference for myself). I have a worrying suspicion that this sub-selection feature was built on a fatally-flawed assumption that the |
…RES v4.0.0 introduced with MapGuide RFC 176. It is this version of the operation that allows us to properly implement feature sub-selection. As a result, we no longer support feature sub-selection for versions older than 4.0 as we cannot rely on array index lookup to locate the correct selection key.
Ok, here's the deal. I have a fix, but this requires a new version of Because the fix requires a new API, it means I have to remove support for this feature on versions older than MGOS 4.0 as I cannot rely on array index lookup to correctly find the corresponding feature selection key (which is how feature sub-selection is currently implemented). The fix is parked on a feature branch pending approval/adoption of the above RFC. |
I have received reports that the feature sub-selection may be highlighting the wrong feature. That is: The attributes of the current feature does not reflect what was sub-selected.
The text was updated successfully, but these errors were encountered: