Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buffer/query/theme/featureinfo/redline/quickplot work with existing fusion backend. #224

Closed
8 tasks done
jumpinjackie opened this issue May 8, 2017 · 0 comments
Closed
8 tasks done

Make buffer/query/theme/featureinfo/redline/quickplot work with existing fusion backend. #224

jumpinjackie opened this issue May 8, 2017 · 0 comments
Assignees
@jumpinjackie
Labels
catch-up
Milestone
0.9

Comments

@jumpinjackie
Copy link
Owner

jumpinjackie commented May 8, 2017 •
edited
Loading

The PHP code under viewer/server is a verbatim copy of the fusion backend code.

Rather than duplicate a whole bunch of backend code, I think it is safe to assume Fusion is already present and that our viewer is deployed in a sibling folder to fusion and just redirect our buffer/query/theme/featureinfo/redline/quickplot commands to there instead.

This will simplify the npm module story as we can hold onto the above assumption and not have to bundle a whole bunch of redundant PHP code (in a JS package registry!) and burden the package consumer with a whole bunch of webpack trickery to copy our version of the PHP backend to the right spot for these aformentioned tools to work.

The following tools should leverage the existing Fusion backend where possible.

  • Buffer
  • Query
  • Theme
  • FeatureInfo
  • Redline
  • QuickPlot
  • Search Commands
  • Select Within

As an unintentional (but useful) side-effect, this will also force us to have to shim/polyfill various parts of the current Fusion API, which will go some way towards addressing #145
@jumpinjackie jumpinjackie added this to the 0.9 milestone May 8, 2017
@jumpinjackie jumpinjackie self-assigned this May 8, 2017
jumpinjackie added a commit that referenced this issue May 8, 2017
@jumpinjackie
#224: Move to using the existing fusion backend for buffer/query/them…
4dce024 
…e/etc

 - Rename ajax-viewer-shim to viewer-shim as this is now a shim for both AJAX and Fusion viewer APIs
 - Shim enough Fusion APIs to allow theme to work
 - Shim enough Fusion APIs to allow buffer to work
jumpinjackie added a commit that referenced this issue May 8, 2017
@jumpinjackie
#224: Allow out-of-view programmatic selection, making selection work…
b747eb5 
… in Fusion query widget.

Also change IMapViewer.queryMapFeature to allow for Partial<> query options
jumpinjackie added a commit that referenced this issue May 8, 2017
@jumpinjackie
#224:
fe23a2e 
 - Restore upper-case parameters for Redline
 - Stub extra APIs for Redline
jumpinjackie added a commit that referenced this issue May 8, 2017
@jumpinjackie
#224: Point QuickPlot URL to the existing Fusion one.
ec5e635
jumpinjackie added a commit that referenced this issue May 8, 2017
@jumpinjackie
#224: More commentary
bd6aca4
jumpinjackie added a commit that referenced this issue May 9, 2017
@jumpinjackie
#224: Shim required Fusion APIs to make Query widget work
a5ad566
jumpinjackie added a commit that referenced this issue May 9, 2017
@jumpinjackie
#224: Shim the following APIs to supoprt the Redline widget:
24dc14b 
 - Fusion.ajaxRequest
 - [MapWidget].digitizeLine
jumpinjackie added a commit that referenced this issue May 9, 2017
@jumpinjackie
#224: Use IMapViewer.setSelectionXml for the [MapWidget].query polyfill
c47a079
jumpinjackie added a commit that referenced this issue May 9, 2017
@jumpinjackie
#224: Add support for the zoomTo parameter of [MapWidget].setSelection()
f2f6e45 
This allows zooming to selected features from the Fusion search widget to work.
jumpinjackie added a commit that referenced this issue May 9, 2017
@jumpinjackie
#224: Now that we have buffer/query/theme/featureinfo/redline/quickpl…
8665d35 
…ot working against the existing Fusion backend, nuke our verbatim copy under viewer/server (except for the Task Pane placeholder page)
@jumpinjackie jumpinjackie reopened this May 23, 2017
jumpinjackie added a commit that referenced this issue May 23, 2017
@jumpinjackie
#224: Get Select Within working against existing Fusion backend
f86233c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumpinjackie jumpinjackie

Labels
catch-up
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
1 participant
@jumpinjackie