-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MOI.Parameter and fixes tests #140
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 95.26% 94.08% -1.18%
==========================================
Files 4 4
Lines 1034 1065 +31
==========================================
+ Hits 985 1002 +17
- Misses 49 63 +14 ☔ View full report in Codecov by Sentry. |
src/ParametricOptInterface.jl
Outdated
# MathOptInterface.Parameter(5.0) | ||
# ``` | ||
# """ | ||
# struct Parameter <: MOI.AbstractScalarSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this backwards compatible, you could do const Parameter = MOI.Parameter{Float64}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking about that still.
Maybe it is better just to break it sooner rather than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe
Project.toml also needs to be updated with minimum MOI version |
close #132
close #136
replaces #139
replaces #137