Switch to MOI.Parameter and fixes tests #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 95.26% 94.08% -1.18%
==========================================
Files 4 4
Lines 1034 1065 +31
==========================================
+ Hits 985 1002 +17
- Misses 49 63 +14 ☔ View full report in Codecov by Sentry. |
odow
reviewed
Nov 30, 2023
odow
reviewed
Nov 30, 2023
odow
reviewed
Nov 30, 2023
src/ParametricOptInterface.jl
Outdated
| # MathOptInterface.Parameter(5.0) | ||
| # ``` | ||
| # """ | ||
| # struct Parameter <: MOI.AbstractScalarSet |
There was a problem hiding this comment.
To make this backwards compatible, you could do const Parameter = MOI.Parameter{Float64}?
There was a problem hiding this comment.
I am thinking about that still.
Maybe it is better just to break it sooner rather than later.
|
Project.toml also needs to be updated with minimum MOI version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #132
close #136
replaces #139
replaces #137