Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListOfConstraintTypesPresent #137

Closed
wants to merge 2 commits into from

Conversation

ianfiske
Copy link

Fixes #136

@ianfiske
Copy link
Author

ianfiske commented Oct 12, 2023

Before these changes, 6 tests failed (test_moi_ipopt/test_linear_transform). After these changes, the same test location and count of tests fail. The remaining tests pass as before.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da2c498) 95.15% compared to head (4ecdf53) 95.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   95.15%   95.18%   +0.02%     
==========================================
  Files           4        4              
  Lines        1033     1038       +5     
==========================================
+ Hits          983      988       +5     
  Misses         50       50              
Files Coverage Δ
src/ParametricOptInterface.jl 91.48% <87.50%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianfiske
Copy link
Author

@joaquimg It looks like #139 is possibly trying to fix the same issue as this PR, but in a more comprehensive way? If completion of that PR is a ways off, it would be great if we could get this one merged and released because the errors this PR corrects are a bit problematic. Thoughts?

@joaquimg
Copy link
Member

joaquimg commented Dec 1, 2023

replaced by #140

@joaquimg joaquimg closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MOI.get(model, MOI.ListOfConstraintTypesPresent()) throws BoundsError
2 participants