Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguity with new mul! methods in Julia v1.7 #127

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 1, 2021

New mul! methods were added in JuliaLang/julia#29634 so we now have to add methods to fix ambiguities.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #127 (61dbe44) into master (c4c2e7a) will decrease coverage by 1.07%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   86.23%   85.15%   -1.08%     
==========================================
  Files          20       20              
  Lines        1765     1785      +20     
==========================================
- Hits         1522     1520       -2     
- Misses        243      265      +22     
Impacted Files Coverage Δ
src/dispatch.jl 53.29% <26.66%> (-7.94%) ⬇️
src/rewrite.jl 80.61% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c2e7a...61dbe44. Read the comment docs.

@blegat blegat merged commit e2ca1b0 into master Dec 26, 2021
@odow odow deleted the bl/mulab branch February 4, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant