-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Optim to list of solvers #3624
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3624 +/- ##
==========================================
+ Coverage 98.21% 98.29% +0.07%
==========================================
Files 43 43
Lines 5653 5676 +23
==========================================
+ Hits 5552 5579 +27
+ Misses 101 97 -4 ☔ View full report in Codecov by Sentry. |
@blegat the issue now is that the Optim README doesn't conform to our needs: https://jump.dev/JuMP.jl/previews/PR3624/packages/Optim/ Perhaps we could just omit the README for now? |
where can I find the requirements? |
It needs to be documenter markdown, not GitHub markdown 😄 You can see from the image above. The links don't work, and it needs to be |
If you have time! Otherwise I'll try to get to it early next week. |
Preview https://jump-dev.github.io/JuMP.jl/previews/PR3624
Basic
MOI.Test.runtests
. Some test excludes arepermissible, but the reason for skipping a particular test should be
documented.
use the solver with JuMP Update README example to new MOI nonlinear interface JuliaNLSolvers/Optim.jl#1059
Documentation
docs/src/installation.md
Optional
docs/packages.toml
cc @pkofod