Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DimensionalData extension #3413

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Add DimensionalData extension #3413

merged 13 commits into from
Jul 31, 2023

Conversation

odow
Copy link
Member

@odow odow commented Jun 7, 2023

This PR is a replacement for #3383. I've added a new branch to the jump-dev remote so that we can generate documentation previews.

https://jump.dev/JuMP.jl/previews/PR3413/extensions/DimensionalData/

I'm going to mark this as closing #3214. I don't think we need to implement methods for DenseAxisArray, we just need to make it easier to integrate with other array packages.

Closes #3214

docs/make.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (0ba286e) 98.00% compared to head (74d513f) 97.98%.

❗ Current head 74d513f differs from pull request most recent head 4e08d62. Consider uploading reports for the commit 4e08d62 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
- Coverage   98.00%   97.98%   -0.02%     
==========================================
  Files          34       36       +2     
  Lines        5003     4966      -37     
==========================================
- Hits         4903     4866      -37     
  Misses        100      100              
Files Changed Coverage Δ
ext/JuMPDimensionalDataExt.jl 100.00% <100.00%> (ø)
ext/test_DimensionalData.jl 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Jun 7, 2023

So this PR now has tests and documentation.

It seems reasonable to merge, but it's worth a discussion on the long-term maintenance cost vs the additional features that are offered.

@odow
Copy link
Member Author

odow commented Jun 22, 2023

Discussed breaking changes in DimensionalData here: rafaqz/DimensionalData.jl#491. None are immediately planned, but there might be a couple before v1.0.

Any changes are very unlikely to impact the code in JuMP, so consensus from the monthly call seemed to be that we should move forward with this case, and re-evaluate other extensions on a case-by-case basis.

I am interested to see how the Pkg extensions go more generally, and whether they lead to questions on the forum.

@odow
Copy link
Member Author

odow commented Jul 31, 2023

Discussed and approved during the hackathon.

@odow odow merged commit a325eb6 into master Jul 31, 2023
11 checks passed
@odow odow deleted the 1.9-ext branch July 31, 2023 23:12
@odow odow mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Containers] support ArrayInterface.jl traits
2 participants