Prep for v1.11.0 #3340
Merged
Prep for v1.11.0 #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
odow
commented
May 3, 2023
•
odow
commented
- extension-tests https://github.com/jump-dev/JuMP.jl/actions/runs/4867072087
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3340 +/- ##
==========================================
+ Coverage 97.92% 98.05% +0.12%
==========================================
Files 34 34
Lines 4874 4874
==========================================
+ Hits 4773 4779 +6
+ Misses 101 95 -6 ☔ View full report in Codecov by Sentry. |
|
cc @pulsipher it's good having the |
mlubin
reviewed
May 3, 2023
| @@ -30,11 +30,7 @@ set_silent(model) | |||
| @objective(model, Min, [3x1 + x2, -x1 - 2x2]) | |||
| @constraint(model, 3x1 - x2 <= 6) | |||
| set_optimizer(model, () -> MOA.Optimizer(HiGHS.Optimizer)) | |||
| set_attribute( | |||
There was a problem hiding this comment.
Yip. I just noticed when I checked the versions we were using. Didn't seem worth a separate PR when I was doing this one.
mlubin
approved these changes
May 3, 2023
Yes this this will be very nice to have as a warning/safeguard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.