Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containers] fix when axis is Vector{Any} #3280

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Mar 12, 2023

Closes #3279

@odow odow added Type: Bug Category: Containers Related to the Containers submodule labels Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3dd83b5) 98.14% compared to head (1f9a861) 98.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3280   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          34       34           
  Lines        4843     4847    +4     
=======================================
+ Hits         4753     4757    +4     
  Misses         90       90           
Impacted Files Coverage Δ
src/Containers/DenseAxisArray.jl 96.41% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow requested a review from blegat March 15, 2023 19:02
@odow
Copy link
Member Author

odow commented Mar 16, 2023

@blegat bump

@blegat
Copy link
Member

blegat commented Mar 22, 2023

I'm still not convinced that there is no edge cases like #3280 (comment)
I feel this is getting into dark territory

@odow odow added Status: Needs review Status: Needs developer call This should be discussed on a monthly developer call and removed Status: Needs review labels Mar 22, 2023
@odow odow removed the Status: Needs developer call This should be discussed on a monthly developer call label Apr 4, 2023
@odow
Copy link
Member Author

odow commented Apr 4, 2023

@blegat what do you think of this?

@odow odow merged commit a287531 into master Apr 5, 2023
@odow odow deleted the od/fix-container-any branch April 5, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Containers Related to the Containers submodule Type: Bug
Development

Successfully merging this pull request may close these issues.

Containers can't index when key is Vector{Any}
2 participants