Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support inequality syntax for HermitianPSDCone (#3256)" #3264

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Mar 3, 2023

This reverts commit ac20706.

As mentioned in #3256 (comment), it's an inconsistent behavior with the Symmetric case because when you get dual, you will get a Hermitian matrix while it's not the case for Symmetric.

@blegat blegat mentioned this pull request Mar 3, 2023
14 tasks
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.93 ⚠️

Comparison is base (b9cf868) 98.11% compared to head (bf6f4ab) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   98.11%   97.19%   -0.93%     
==========================================
  Files          34       34              
  Lines        4719     4665      -54     
==========================================
- Hits         4630     4534      -96     
- Misses         89      131      +42     
Impacted Files Coverage Δ
src/sd.jl 99.30% <ø> (-0.70%) ⬇️
src/precompile.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Containers/vectorized_product_iterator.jl 90.90% <0.00%> (-4.55%) ⬇️
src/Containers/DenseAxisArray.jl 93.10% <0.00%> (-2.76%) ⬇️
src/JuMP.jl 95.41% <0.00%> (-1.47%) ⬇️
src/macros.jl 97.27% <0.00%> (-1.31%) ⬇️
src/solution_summary.jl 96.42% <0.00%> (-1.20%) ⬇️
src/aff_expr.jl 96.12% <0.00%> (-1.17%) ⬇️
src/nlp.jl 98.96% <0.00%> (-1.04%) ⬇️
src/Containers/Containers.jl 90.90% <0.00%> (-0.76%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit b5d3004 into master Mar 3, 2023
@odow odow deleted the bl/non_hermitian_constraint branch March 3, 2023 18:52
@odow
Copy link
Member

odow commented Mar 3, 2023

I misunderstood your comment 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants