Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove_bridge, print_active_bridges, and document #3259

Merged
merged 16 commits into from
Mar 2, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Mar 1, 2023

As suggested by @blegat in #2348 (comment), we're actually missing a few key tools to help the user understand the bridges.

This PR adds JuMP.remove_bridge and JuMP.print_active_bridges, and then extends the ellipse approximation tutorial to investigate alternate formulations.

Preview link: https://jump.dev/JuMP.jl/previews/PR3259/tutorials/conic/ellipse_approx

@odow odow added Type: Documentation Category: Internals Related to JuMP internals labels Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (60392b0) 98.10% compared to head (7fe4bd5) 98.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3259   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          34       34           
  Lines        4702     4704    +2     
=======================================
+ Hits         4613     4615    +2     
  Misses         89       89           
Impacted Files Coverage Δ
src/JuMP.jl 96.87% <100.00%> (+0.04%) ⬆️
src/optimizer_interface.jl 96.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: James Foster <38274066+jd-foster@users.noreply.github.com>
@odow
Copy link
Member Author

odow commented Mar 2, 2023

This tutorial tells a nice story, and it's a pretty great demo of all the complexity that JuMP is sorting through under the hood!

It's quite nice to inspect the model, rewrite it to be closer to something that SCS supports, and try out an alternative formulation that is faster.

@jd-foster
Copy link
Collaborator

Can you PR to a PR? Let's find out.

@odow
Copy link
Member Author

odow commented Mar 2, 2023

Yip. Just make it like normal, then you can change it at the od/remove_bridge branch instead of master with the "Edit" button

image

@jd-foster
Copy link
Collaborator

Ok, I'm stopping with commits to let you review, otherwise we're just overwriting each other.

@jd-foster
Copy link
Collaborator

Are you able to merge commit the PR? - the constraint needs to be t <= (detZ)^(1/n) not t >= ...

@odow
Copy link
Member Author

odow commented Mar 2, 2023

Sorry, we kinda went over the top of each other there. I have no further plans for this PR, so if you have changes you should be safe to try a new PR 😄

@jd-foster
Copy link
Collaborator

All good! All my changes got added on your side in the end.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, looks good modulo the minor comment at the end

@odow odow mentioned this pull request Mar 2, 2023
14 tasks
@odow odow merged commit b9cf868 into master Mar 2, 2023
@odow odow deleted the od/remove_bridge branch March 2, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants