-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove_bridge, print_active_bridges, and document #3259
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3259 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 34 34
Lines 4702 4704 +2
=======================================
+ Hits 4613 4615 +2
Misses 89 89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: James Foster <38274066+jd-foster@users.noreply.github.com>
This tutorial tells a nice story, and it's a pretty great demo of all the complexity that JuMP is sorting through under the hood! It's quite nice to inspect the model, rewrite it to be closer to something that SCS supports, and try out an alternative formulation that is faster. |
Can you PR to a PR? Let's find out. |
Ok, I'm stopping with commits to let you review, otherwise we're just overwriting each other. |
Are you able to merge commit the PR? - the constraint needs to be |
Sorry, we kinda went over the top of each other there. I have no further plans for this PR, so if you have changes you should be safe to try a new PR 😄 |
All good! All my changes got added on your side in the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, looks good modulo the minor comment at the end
As suggested by @blegat in #2348 (comment), we're actually missing a few key tools to help the user understand the bridges.
This PR adds
JuMP.remove_bridge
andJuMP.print_active_bridges
, and then extends the ellipse approximation tutorial to investigate alternate formulations.Preview link: https://jump.dev/JuMP.jl/previews/PR3259/tutorials/conic/ellipse_approx