Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests which use JuMPExtension.jl #3162

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Refactor tests which use JuMPExtension.jl #3162

merged 3 commits into from
Jan 1, 2023

Conversation

odow
Copy link
Member

@odow odow commented Dec 22, 2022

I started looking into #1711

This is a preliminary step to making the JuMPExtension tests more widely accessible. For a start, we need to know which tests to make available, and to have a standardized call signature for them.

I still need to figure out exactly what it would look like. Perhaps we could put them all in a separate submodule of the tests/JuMPExtensionTests and then packages could run

include(joinpath(pathof(JuMP), "test", "JuMPExtensionTests", "JuMPExtensionTests.jl")

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 97.70% // Head: 97.70% // No change to project coverage 👍

Coverage data is based on head (545ba21) compared to base (c57514d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3162   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          33       33           
  Lines        4485     4485           
=======================================
  Hits         4382     4382           
  Misses        103      103           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

odow and others added 2 commits January 1, 2023 13:54
This is a preliminary step to making the JuMPExtension tests more
widely accessible. For a start, we need to know which tests to make
available, and to have a standardized call signature for them.
@odow odow merged commit dbf70e1 into master Jan 1, 2023
@odow odow deleted the od/test-extensions branch January 1, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant