Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanatory warning before OptimizeNotCalled error #3156

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

odow
Copy link
Member

@odow odow commented Dec 19, 2022

Closes #3155

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 97.69% // Head: 97.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2971faa) compared to base (d986530).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3156   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          33       33           
  Lines        4462     4464    +2     
=======================================
+ Hits         4359     4361    +2     
  Misses        103      103           
Impacted Files Coverage Δ
src/JuMP.jl 95.83% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Dec 20, 2022

@pulsipher are you happy if I merge this? Or do you still want something else?

@pulsipher
Copy link
Contributor

Merge away :)

@odow odow merged commit ee382c1 into master Dec 20, 2022
@odow odow deleted the od/optimize-not-called branch December 20, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improve Error Messages for Querying Modified Models
2 participants