Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces length/size by eachindex/axes #3149

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Replaces length/size by eachindex/axes #3149

merged 2 commits into from
Dec 13, 2022

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 13, 2022

This resolves the following warnings in VSCode:

Indexing with indices obtained from length, size is discouraged. Use eachindex or axes instead.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 97.69% // Head: 97.69% // No change to project coverage 👍

Coverage data is based on head (0a211ec) compared to base (856dcc6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3149   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          33       33           
  Lines        4460     4460           
=======================================
  Hits         4357     4357           
  Misses        103      103           
Impacted Files Coverage Δ
src/print.jl 99.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit 73d05bf into master Dec 13, 2022
@odow odow deleted the bl/eachindex_axes branch December 13, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants