Add support for skew symmetric variables #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 92.19% 92.21% +0.02%
==========================================
Files 43 43
Lines 4597 4613 +16
==========================================
+ Hits 4238 4254 +16
Misses 359 359
Continue to review full report at Codecov.
|
odow
commented
Dec 15, 2020
test/variable.jl
Outdated
| @@ -482,6 +482,30 @@ function test_variable_symmetric(ModelType, ::Any) | |||
| @test y[1, 2] === y[2, 1] | |||
| end | |||
|
|
|||
| function test_variable_skewsymmetric(ModelType, ::Any) | |||
| model = ModelType() | |||
| @variable(model, x[1:2, 1:2] in SkewSymMatrixSpace()) | |||
There was a problem hiding this comment.
So I've been playing with this, and the syntax is pretty restrictive. (This also applied to symmetric matrices.)
For example, we don't support
@variable(model, x[2:3, 2:3] in SkewSymMatrixSpace())because it isn't apparent you can have a symmetric DenseAxisArray.
But if users are forced to write
@variable(model, x[1:3, 1:3] in SkewSymMatrixSpace())why not just
@variable(model, X in SkewSymMatrixSpace(3))For anonymous variables, we could support
X = @variable(model, _ in SkewSymMatrixSpace(3))
blegat
approved these changes
Dec 18, 2020
|
We can keep discussing different syntax in the next monthly developer call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from #2147
Closes #2146
cc @frederikgeth