Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature custom width and height of scanning area #432

Conversation

OrangeSofter
Copy link
Contributor

@OrangeSofter OrangeSofter commented Oct 1, 2021

Developing feature #368 in progress

@OrangeSofter OrangeSofter changed the title Feature custom width and height of scanning area #368 Feature custom width and height of scanning area Oct 1, 2021
@juliansteenbakker
Copy link
Collaborator

Can you please run flutter format . and commit changes?

@OrangeSofter
Copy link
Contributor Author

OrangeSofter commented Oct 5, 2021

Yes, i did it

@OrangeSofter
Copy link
Contributor Author

Feature #368 done

@juliansteenbakker
Copy link
Collaborator

First of all thank you for your contribution. I have checked it, however i think it would be best if we can leave the current implementation in place, and add this as an optional feature. Otherwise this would be quite a breaking change. I think the best would be to just leave the cutOutSize in place, and to either accept this, OR the separate scan area width and height.

What do you think about this?

@OrangeSofter
Copy link
Contributor Author

At the moment, the constructor has a cutOutSize parameter, so backward compatibility is not broken.
It is assumed that either cutOutSize or cutOutWidth and cutOutHeight will be passed to the constructor, otherwise an exception is thrown
Are you saying you need to create a second constructor?

@juliansteenbakker
Copy link
Collaborator

My fault, i thought this removes all references to cutOutSize but it doesn't. Thanks !

@juliansteenbakker juliansteenbakker merged commit 981ab7a into juliuscanute:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants