Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py37 deprecations + psql container startup #41

Merged
merged 2 commits into from
Mar 22, 2020

Conversation

bodik
Copy link
Contributor

@bodik bodik commented Feb 28, 2020

Fix py37 deprecations + psql container startup

```
python3.7/site-packages/sqlalchemy_filters/filters.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    from collections import Iterable, namedtuple
```
@nyejon
Copy link

nyejon commented Mar 7, 2020

@juliotrigo This would be great if it could be merged!

@juliotrigo
Copy link
Owner

juliotrigo commented Mar 11, 2020

@bodik Thanks for the contribution! I'll take a look at it.
@nyejon I will try to work on the pending PRs in the coming weeks.

Copy link
Owner

@juliotrigo juliotrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks great!

Thanks for the contribution @bodik

@juliotrigo juliotrigo merged commit 48899e3 into juliotrigo:master Mar 22, 2020
@bodik bodik deleted the fix-py37_deprecations branch July 1, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants