Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sqlalchemy any operator to query arrays #36

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

bodik
Copy link
Contributor

@bodik bodik commented May 13, 2019

Add support for sqlalchemy any operator to query arrays. "any" filter models having value in attribute of array type, "not_all" filter models not having value in attribute of array. Adds postgresql specific tests/models for querying arrays.

@bodik
Copy link
Contributor Author

bodik commented Jun 23, 2019

rebased to master

@bodik
Copy link
Contributor Author

bodik commented Aug 29, 2019

hi, any chance to have this reviewed or even merged ?

Copy link
Owner

@juliotrigo juliotrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @bodik !

I have left a few comments.

test/interface/test_filters.py Outdated Show resolved Hide resolved
test/interface/test_filters.py Outdated Show resolved Hide resolved
test/interface/test_filters.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@bodik bodik changed the title Add support for sqlalchemy any operator to query arrays WIP: Add support for sqlalchemy any operator to query arrays Mar 24, 2020
@bodik bodik force-pushed the feature-any_operator branch 2 times, most recently from ea4de2f to 7181710 Compare March 24, 2020 15:17
@bodik bodik changed the title WIP: Add support for sqlalchemy any operator to query arrays Add support for sqlalchemy any operator to query arrays Mar 24, 2020
@bodik
Copy link
Contributor Author

bodik commented Mar 24, 2020

based on the comments so far I have:

  • refactored tests naming as suggested
  • enhanced tests cases and in turn fixed/re-implemented not_all to not_any operator as the original implementation did not work correctly under sqla1.0 for new tests
  • rephrased the documentation
  • squashed and rebased to master

Copy link
Owner

@juliotrigo juliotrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

It's good that we have identified the issues and that tests cover all the different cases now.

One final suggestion about the documentation.

README.rst Outdated Show resolved Hide resolved
@bodik
Copy link
Contributor Author

bodik commented Mar 24, 2020

not sure why travis build is not linked but docs were updated

Copy link
Owner

@juliotrigo juliotrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Not sure why Travis is not building. There was another PR merged to master an hour ago and maybe that's related. Please try to update your branch with master and push the changes to this branch.

…erator.

* "any"/"not_any" operators allow to filter query by having/not having value in attribute of type array
* corresponding tests and test models
Copy link
Owner

@juliotrigo juliotrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@juliotrigo juliotrigo merged commit 8a1492b into juliotrigo:master Mar 25, 2020
@bodik bodik deleted the feature-any_operator branch July 1, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants