-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sqlalchemy any operator to query arrays #36
Conversation
ae0c9cd
to
59dfa72
Compare
rebased to master |
hi, any chance to have this reviewed or even merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition @bodik !
I have left a few comments.
59dfa72
to
b0e1b4f
Compare
ea4de2f
to
7181710
Compare
based on the comments so far I have:
|
7181710
to
3ecf8e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
It's good that we have identified the issues and that tests cover all the different cases now.
One final suggestion about the documentation.
3ecf8e0
to
66638bd
Compare
not sure why travis build is not linked but docs were updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Not sure why Travis is not building. There was another PR merged to master
an hour ago and maybe that's related. Please try to update your branch with master
and push the changes to this branch.
…erator. * "any"/"not_any" operators allow to filter query by having/not having value in attribute of type array * corresponding tests and test models
66638bd
to
f633ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Add support for sqlalchemy any operator to query arrays. "any" filter models having value in attribute of array type, "not_all" filter models not having value in attribute of array. Adds postgresql specific tests/models for querying arrays.