Fixes #29 - Adjusted variables to check against #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added both "count" and "each" since they are potential dynamics that could be in a resource. This feels a little like it could be more automated to gather the variable context from each resource vs having to define these variables manually. NOTE: This change (and this method of variable definition in contexts in general) introuces false positives. An example is using the 'each' variable in a place where you have not also used the 'for_each' attribute on a resource. The parser language server will PASS but terraform will fail.
|
@juliosueiras , this bug is a bit painful, what is the release schedule, blockers, and do you need any help to get a release out with this fix? [Please point me somewhere else where releases are discussed if this is inappropriate.] cc: @endzyme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added both "count" and "each" since they are potential dynamics that
could be in a resource. This feels a little like it could be more
automated to gather the variable context from each resource vs having to
define these variables manually.
NOTE: This change (and this method of variable definition in contexts in
general) introuces false positives. An example is using the 'each'
variable in a place where you have not also used the 'for_each'
attribute on a resource. The parser language server will PASS but
terraform will fail.