-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Feature: add useScrollLock
hook
#479
✨ Feature: add useScrollLock
hook
#479
Conversation
🦋 Changeset detectedLatest commit: fb0b178 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Duplicate of |
The most useful feature is auto lock/unlock, its based on https://usehooks.com/uselockbodyscroll but has a larger feature set. I think this can also replace |
@juliencrn, Hey I was busy with exams and didn't check much, I see that the hooks I made PRs for are still sitting unreviewed. Can you please review and accept the PRs in mean while. I would be free from tommorow, when I could work more on the project. Thanks |
- remove the internal state - add JSDoc param details - add width reflow support - simplify a bit the useEffect - make the demo working - remove eslint-disable comment
Hi @BlankParticle,
What do you think about it? |
Width reflow should be an option that is enabled by default but can be disabled if the user wants |
We also should remove this file |
I will do that in a new PR |
Oh, you did the work on site already. I think we are good to merge 🚀 |
On a side note, there are new pull requests coming everyday, Do you want me to help in reviewing them? |
Yes totally, it's more than welcome 🙌 Thank you |
Adds a new hook called
useScrollLock
that allows you to automatically/programmatically lock the scroll of target element.Todo
useScrollLock
hook