Simplify the key setup instructions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaMann
requested changes
May 22, 2022
README.md
Outdated
| @@ -11,6 +11,7 @@ on: | |||
|
|
|||
| jobs: | |||
| Documenter: | |||
| permissions: write-all | |||
There was a problem hiding this comment.
This is not a good practice. Instead, only the minimal permissions that are needed to make the workflow work should be given to the token.
There was a problem hiding this comment.
Well spotted 👍 Based on https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions?ref=#permissions, the permissions are now set to
permissions:
contents: write
I've tested this in a repository of mine (https://github.com/rikhuijzer/DiscountedCashFlows.jl/commits/main).
SaschaMann
approved these changes
May 26, 2022
|
Thanks! |
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually adding a separate
DOCUMENTER_KEYshouldn't be necessary. See JuliaDocs/Documenter.jl#1819 for more info.