-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source juju_application #630
base: main
Are you sure you want to change the base?
Conversation
1 similar comment
61af9f7
to
cba4340
Compare
cba4340
to
d838393
Compare
ed4b00c
to
a979d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments/documentation adjustments requested. Otherwise LGTM.
a979d62
to
9c24683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about to why this is new data source is useful if it no longer contains the trust and units value?
9c24683
to
1a5985c
Compare
20a5e8d
to
b254b6a
Compare
b254b6a
to
614549b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please update the PR description to explain the use case for this data source and update the documentation to also include the potential use cases.
Description
Creation of a
juju_application
data sourceThe data source can be used in cases where deployment topology is split between different teams but there is still a lot of inter-operation between services
As any data source this prevents hardcoding of values, in this case application names, without validation
Type of change
Environment
Juju controller version:
3.5+
Terraform version:
1.8.2+
QA steps
Manual QA steps should be done to test this PR.