CSS-9769 Generic access resource crud #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
CSS-9769-generic-access-crud
branch
3 times, most recently
from
d0a93a9 to
6ffb42d
Compare
alesstimec
approved these changes
Sep 5, 2024
kian99
force-pushed
the
CSS-9769-generic-access-crud
branch
2 times, most recently
from
08b31c9 to
8508652
Compare
hmlanigan
reviewed
Sep 10, 2024
hmlanigan
reviewed
Sep 10, 2024
kian99
force-pushed
the
CSS-9769-generic-access-crud
branch
from
8508652 to
46e2847
Compare
- Modify the jaasAccessModelResourceModel struct to avoid embedding - Embedding doesn't work with Terraform's reflection. - Modify the resourceInfo interface to perform plan get/saves on the parent object.
kian99
force-pushed
the
CSS-9769-generic-access-crud
branch
3 times, most recently
from
11ff056 to
615f980
Compare
- Remove globals for isJAAS placing them on the sharedClient struct instead. - Improved error messages when Juju client calls fail. - Use template strings in tests.
kian99
force-pushed
the
CSS-9769-generic-access-crud
branch
from
615f980 to
03f53fb
Compare
|
@hmlanigan Can you please merge this PR, all tests are passing. |
jujubot
added a commit
that referenced
this pull request
Sep 17, 2024
#571 ## Description This PR builds on top of #552. In this PR we implement imports for any resources built on top of the JAAS generic access resource. Imports are enabled via a string of the format `resourceTag:accessLevel`. The concrete resource must also implement an import "hint" to guide users, e.g. the JAAS model access resource hints that the import string must be something like "model-UUID:writer". Fixes: [CSS-10237](https://warthogs.atlassian.net/browse/CSS-10237) ## Type of change - Change existing resource (implement imports) [CSS-10237]: https://warthogs.atlassian.net/browse/CSS-10237?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #561, review from the second commit to skip the changes from that PR.This PR implements CRUD methods for the generic resource access object.
The generic resource access object constructs tuples based on the user defined set of users/groups/service-accounts that should have a level of access to a particular resource.
Type of change
Additional notes
Addresses CSS-9769