Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bonus tokens by function adjustavailableTokens (#31) #31

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

kingsamchen
Copy link
Contributor

Once adjustavailableTokens() is called, the number of tokens should be
updated in accordance with the tick even if the buket is full.

Semantically, extra tokens are discarded though we, in fact, simply
returns from the function.

Once adjustavailableTokens() is called, the number of tokens should be
updated in accordance with the tick even if the buket is full.

Semantically, extra tokens are discarded though we, in fact, simply
returns from the function.
ratelimit.go Show resolved Hide resolved
Copy link
Member

@manadart manadart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this.

@manadart
Copy link
Member

manadart commented Oct 2, 2019

$$merge$$

Edit: No bot merging manually.

@manadart manadart merged commit f60b320 into juju:master Oct 2, 2019
@manadart manadart changed the title Fix bonus tokens by function adjustavailableTokens (#30) Fix bonus tokens by function adjustavailableTokens (#31) Oct 2, 2019
jujubot added a commit to juju/juju that referenced this pull request Oct 2, 2019
#10671

## Description of change

Updates the _juju/ratelimit_ dependency, which just received a bug-fix.

See: juju/ratelimit#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants