Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: type hints for the connnection class #1189

Merged
merged 10 commits into from
Nov 19, 2024
Merged

chore: type hints for the connnection class #1189

merged 10 commits into from
Nov 19, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 14, 2024 •
edited
Loading

Pull the Connection type hints from #1097

Only minor cleanup beyond that, no logical changes.

@dimaqq dimaqq mentioned this pull request Nov 15, 2024
Closed
@dimaqq dimaqq force-pushed the chore-connnection-types branch from ae6f49c to 1a23a60 Compare November 18, 2024 02:23
@dimaqq dimaqq changed the title Chore connnection types chore: type hints for the connnection class Nov 18, 2024
@dimaqq dimaqq marked this pull request as ready for review November 18, 2024 02:26
james-garner-canonical
james-garner-canonical requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a lot of comments. You can resolve most without any changes, but I think it would be nice to use something a bit more readable for the for ... else one.

juju/client/connection.py Outdated Show resolved Hide resolved
juju/client/connection.py Outdated Show resolved Hide resolved
juju/client/connection.py Show resolved Hide resolved
juju/model.py Outdated Show resolved Hide resolved
juju/model.py Show resolved Hide resolved
juju/utils.py Show resolved Hide resolved
juju/utils.py Show resolved Hide resolved
juju/utils.py Show resolved Hide resolved
juju/model.py Show resolved Hide resolved
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 19, 2024

/merge

@jujubot jujubot merged commit 6a62d83 into juju:main Nov 19, 2024
20 of 22 checks passed
@dimaqq dimaqq deleted the chore-connnection-types branch January 6, 2025 06:47
@dimaqq dimaqq mentioned this pull request Jan 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-garner-canonical james-garner-canonical james-garner-canonical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimaqq @james-garner-canonical @jujubot