Skip to content

Commit

Permalink
Merge pull request #1163 from dimaqq/multiple-juju-versions
Browse files Browse the repository at this point in the history
#1163

Integration tests against Juju 3.1, 3.3, 3.4, 3.5 (was: 3.4)
Unit tests against Python 3.8~3.13 (was: 3.9~3.10)

Notes: Juju 3.6 deprecated some bases (?) and many integration tests fail. Given that it's in beta, deferring that to a separate PR.
  • Loading branch information
jujubot authored Oct 17, 2024
2 parents 0e8c45f + c7abedc commit 35ee88e
Showing 1 changed file with 30 additions and 2 deletions.
32 changes: 30 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: Testing

on: [push, pull_request, workflow_dispatch]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
lint:
name: Linter
Expand Down Expand Up @@ -69,8 +73,12 @@ jobs:
strategy:
matrix:
python:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
- "3.13"
steps:
- name: Check out code
uses: actions/checkout@v4
Expand All @@ -95,6 +103,18 @@ jobs:
# save some resources for now.
# - "3.9"
- "3.10"
juju:
- "3.1/stable"
- "3.3/stable"
- "3.4/stable"
- "3.5/stable"
# A bunch of tests fail with juju.errors.JujuError: base: ubuntu@15.04/stable
# * test_subordinate_units
# * test_destroy_unit
# * test_ssh
# * ...
# - "3.6/beta"
continue-on-error: false # ultimately fail a run if one of the matrix combinations fails
steps:
- name: Check out code
uses: actions/checkout@v4
Expand All @@ -106,7 +126,7 @@ jobs:
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.4/stable
juju-channel: ${{ matrix.juju }}
# 2023-01-11 Commented until we discover a
# clear approach for this.
# - name: Set proxy in controller
Expand Down Expand Up @@ -138,6 +158,7 @@ jobs:
- name: Run integration
# Force one single concurrent test
run: tox -e integration
continue-on-error: true # don't fail early, let other matrix combinations get tested

integration-quarantine:
name: Quarantined Integration Tests
Expand All @@ -148,6 +169,12 @@ jobs:
matrix:
python:
- "3.10"
juju:
- "3.1/stable"
- "3.3/stable"
- "3.4/stable"
- "3.5/stable"
continue-on-error: false # ultimately fail the run if one of the matrix combinations fails
steps:
- name: Check out code
uses: actions/checkout@v3
Expand All @@ -159,6 +186,7 @@ jobs:
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.4/stable
juju-channel: ${{ matrix.juju }}
- name: Run integration
run: tox -e integration-quarantine
continue-on-error: true # don't fail early, let other matrix combinations get tested

0 comments on commit 35ee88e

Please sign in to comment.