[JUJU-593] Add APIVersionInfo to the controller #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmlanigan
changed the title
manadart
approved these changes
Feb 15, 2022
| @@ -94,7 +94,7 @@ func newControllerWithVersion(baseURL, apiVersion, apiKey string) (Controller, e | |||
| Minor: minor, | |||
| } | |||
| controller := &controller{client: client, apiVersion: controllerVersion} | |||
| controller.capabilities, err = controller.readAPIVersionInfo() | |||
| _, _, controller.capabilities, err = controller.readAPIVersionInfo() | |||
There was a problem hiding this comment.
If we cache the capabilities here, there's less point in APIVersionInfo querying fresh and returning potentially (admittedly extremely unlikely) diverging info.
I'd be inclined to cache the version and subversion too, and just return the members in APIVersionInfo without hitting the API again.
There was a problem hiding this comment.
Normally I'd agree, however the purpose here is to have a light weight api call specifically to check connectivity. Otherwise it'd be a call to return the api endpoint used by the client, and call Ping inside the provided.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for verification of the MAAS server and to get the version and subversion strings. Capabilities are cached when NewController is called.