Add Domain to CreateMachineDeviceArgs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes https://bugs.launchpad.net/gomaasapi/+bug/1881647 Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
|
This has been confirmed to work on LXD and this is blocking us fixing our MAAS support so would appreciate a quick turnaround on this one :) |
|
As far as unit tests, there doesn't appear to be anything currently in the way of testing CreateMachineDeviceArgs outside of network Interfaces, the rest is passed straight through CreateDeviceArgs which does have existing Domain testing, so I think this is sufficiently covered. |
howbazaar
approved these changes
Jun 2, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://bugs.launchpad.net/gomaasapi/+bug/1881647
Signed-off-by: Stéphane Graber stgraber@ubuntu.com