Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow devices without pools to be properly parsed #81

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Allow devices without pools to be properly parsed #81

merged 1 commit into from
Aug 12, 2019

Conversation

wallyworld
Copy link
Member

Based on #80 by @stgraber

Allow device responses which do not specify a pool.

@wallyworld wallyworld mentioned this pull request Aug 12, 2019
Closed
babbageclunk
babbageclunk approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 7f9373c into juju:master Aug 12, 2019
@hmlanigan hmlanigan mentioned this pull request Aug 26, 2019
Merged
jujubot added a commit that referenced this pull request Aug 26, 2019
@jujubot
Merge pull request #82 from hmlanigan/machine_pr81
0ab1eb6 
#82

Allow machines without pools to be properly parsed. Make changes for machines, as done for devices in #81 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babbageclunk babbageclunk babbageclunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wallyworld @babbageclunk @jujubot