Add 'domains' endpoint request. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExternalReality
force-pushed
the
add_domain_request
branch
from
01f2c2a to
5451089
Compare
howbazaar
reviewed
May 21, 2018
domain.go
Outdated
| name string | ||
| } | ||
|
|
||
| // implements Domain |
There was a problem hiding this comment.
Commend should start with the name of the function.
domain.go
Outdated
|
|
||
| // ttl live is going to be the zero value if it is null. Thus the time | ||
| // to live will be zero. Would rather user's check for zero or for nil? | ||
| ttl, _ := valid["ttl"].(int) |
There was a problem hiding this comment.
I do wonder if we should just mirror the MAAS behaviour and have *int.
There was a problem hiding this comment.
Just to clarify, TTL = 0 has a valid meaning in DNS (it means don't cache) rather than no TTL meaning use the default value for caching.
I don't think Juju is using the TTL right now, but we should track the data correctly.
domain.go
Outdated
| @@ -0,0 +1,83 @@ | |||
| // Copyright 2018 Canonical Ltd. | |||
| // Licensed under the AGPLv3, see LICENCE file for details. | |||
domain_test.go
Outdated
| @@ -0,0 +1,46 @@ | |||
| // Copyright 2016 Canonical Ltd. | |||
jameinel
approved these changes
May 21, 2018
domain.go
Outdated
|
|
||
| // ttl live is going to be the zero value if it is null. Thus the time | ||
| // to live will be zero. Would rather user's check for zero or for nil? | ||
| ttl, _ := valid["ttl"].(int) |
There was a problem hiding this comment.
Just to clarify, TTL = 0 has a valid meaning in DNS (it means don't cache) rather than no TTL meaning use the default value for caching.
I don't think Juju is using the TTL right now, but we should track the data correctly.
added 3 commits
May 21, 2018 03:54
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
MAAS 2.0'sDomainsendpoint. The only thing one can do with aDomainright now is query its name since this is allJujuwants from it thus far.