Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps. #73

Merged
merged 1 commit into from
May 16, 2018
Merged

Update deps. #73

merged 1 commit into from
May 16, 2018

Conversation

howbazaar
Copy link
Contributor

Use collections/set not utils/set.

Veebers
Veebers reviewed May 16, 2018
View reviewed changes
Copy link

@Veebers Veebers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM (quite straight forward).

Probably worth getting a merge/check job setup for this repo?

dependencies.tsv
github.com/juju/errors git 1b5e39b83d1835fa480e0c2ddefb040ee82d58b3 2015-09-16T12:56:42Z
github.com/juju/loggo git 8477fc936adf0e382d680310047ca27e128a309a 2015-05-27T03:58:39Z
github.com/juju/names git 8a0aa0963bbacdc790914892e9ff942e94d6f795 2016-03-30T15:05:33Z
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is juju/names no longer used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, old and gone.

@howbazaar
Copy link
Contributor Author

!!build!!

@howbazaar
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit 613dc12 into juju:master May 16, 2018
@howbazaar howbazaar deleted the update-deps branch May 16, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veebers Veebers Veebers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howbazaar @Veebers @jujubot