Fix allow storage constraints to search both physical and virtual(logi… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
reviewed
Dec 1, 2017
There was a problem hiding this comment.
If its just exposing a different field (BlockDevice) rather than (PhysicalBlockDevice), that seems good.
Do we know that all entries that we've been reading from PhysicalBlockDevices are present in BlockDevices?
If so, LGTM (caveat some comment tweaks, and we should at least have 1 canned test that grabs a MAAS output for Block devices and mocks the response.)
interfaces.go
Outdated
| @@ -223,6 +223,9 @@ type Machine interface { | |||
|
|
|||
| // BlockDevices returns all the physical and virtual block devices on the machine. | |||
| BlockDevices() []BlockDevice | |||
| // PhysicalBlockDevice returns the physical block device for the machine | |||
There was a problem hiding this comment.
s/PhysicalBlockDevice/BlockDevice/
and probably not "the physical block device"
ExternalReality
changed the title
ExternalReality
force-pushed
the
bug#1729127
branch
from
f55a827 to
fb2bdef
Compare
…cal) block devices.
ExternalReality
force-pushed
the
bug#1729127
branch
from
fb2bdef to
2199ae2
Compare
ExternalReality
changed the title
anastasiamac
approved these changes
Dec 5, 2017
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju-gomaasapi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cal) block devices.