Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose block device id_path attribute #69

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

axw
Copy link
Contributor

@axw axw commented Apr 18, 2017

id_path is the attribute we should be using
in Juju as a stable path identifier for block
devices. The value for "path", which we have
been using, is not always accurate.

id_path is the attribute we should be using
in Juju as a stable path identifier for block
devices. The value for "path", which we have
been using, is not always accurate.
Copy link
Member

@jameinel jameinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that this data has always been there and we've just been ignoring it, LGTM

Also, assuming you've tried this live.

@axw
Copy link
Contributor Author

axw commented Apr 18, 2017

assuming that this data has always been there and we've just been ignoring it, LGTM

Yep.

Also, assuming you've tried this live.

Yep.

@axw
Copy link
Contributor Author

axw commented Apr 18, 2017

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Apr 18, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit 38cd919 into juju:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants