Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around MAAS 1.9.4 bug #68

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

babbageclunk
Copy link
Contributor

Handle a JSON deserialisation error caused by the API version requiring
login in MAAS 1.9.4 - this is fixed in 1.9.5, but we shouldn't break
this for 1.9.4 users right now.

This was masked by the old behaviour of treating any error as an
unsupported version, but now that we're stricter this error becomes apparent.

MAAS bug: https://bugs.launchpad.net/maas/+bug/1583715
Fixes https://bugs.launchpad.net/juju/+bug/1680046

Handle a JSON deserialisation error caused by the API version requiring
login in MAAS 1.9.4 - this is fixed in 1.9.5, but we shouldn't break
this for 1.9.4 users right now.

MAAS bug: https://bugs.launchpad.net/maas/+bug/1583715
Fixes https://bugs.launchpad.net/juju/+bug/1680046
@babbageclunk babbageclunk force-pushed the maas-194-workaround branch from 5428ae9 to 7395576 Compare April 6, 2017 00:17
Copy link

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's about the best way to tackle this. Nice.

@babbageclunk
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Apr 6, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit 985fb1c into juju:master Apr 6, 2017
@babbageclunk babbageclunk deleted the maas-194-workaround branch April 6, 2017 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants