Don't return UnsupportedVersionError for unexpected errors from version check #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAAS 2.x and 1.9 will always return 410 (for known but not supported versions) or 404 (for unknown versions). Only return UnsupportedVersionError for those codes, let other errors bubble up unchanged so that we don't confuse network errors for unsupported versions. Fixes https://bugs.launchpad.net/juju/+bug/1667095
howbazaar
approved these changes
Apr 5, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAAS 2.x and 1.9 will always return 410 (for known but not supported
versions) or 404 (for unknown versions). Only return
UnsupportedVersionError for those codes, let other errors bubble up
unchanged so that we don't confuse network errors for unsupported
versions.
Fixes https://bugs.launchpad.net/juju/+bug/1667095