controller: Accept a versioned API URL #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables creating a controller without doing version probing.
howbazaar
approved these changes
Apr 3, 2017
client_test.go
Outdated
| expectedURL, err := url.Parse("http://example.com/MAAS/api/1.0/") | ||
| c.Assert(err, jc.ErrorIsNil) | ||
| func (suite *ClientSuite) TestAddAPIVersionToURL(c *gc.C) { | ||
| apiurl := AddAPIVersionToURL("http://example.com/MAAS", "1.0") |
There was a problem hiding this comment.
I'd also add a test for the base url having a trailing slash.
| case err == nil: | ||
| return controller, nil | ||
| case IsBadVersionInfoError(err): | ||
| // TODO(babbageclunk): this is bad - it treats transient |
There was a problem hiding this comment.
How can we treat transient network errors differently?
There was a problem hiding this comment.
Not sure - I was leaving that there for myself when I work on the next bug.
If a versioned url is used, the normal version negotiation will be skipped.
babbageclunk
force-pushed
the
allow-versioned-url
branch
from
f57a1dd to
c8e3e67
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if someone tries to specify a particular API version in the URL (e.g.
http://maas.server/MAAS/api/2.0/), we try to tack the version on the end again and fail to connect. Handle this by detecting the version in the URL and skipping the normal loop over supported versions.Fix for this Juju bug: https://bugs.launchpad.net/juju/+bug/1675485